Compatibility changes for V8 7.4 support#142
Merged
SamSaffron merged 3 commits intomasterfrom May 29, 2019
Merged
Conversation
Use of platform::CreateDefaultPlatform has been deprecated[1][2] in favour of NewDefaultPlatform. This commit changes the method invocation and changes the type of the result to std::unique_ptr. [1] v8/v8@ffee558 https://chromium.googlesource.com/v8/v8/+/ffee558e14e28fc8b1f9a3c10ea3615e0d686c7b https://chromium-review.googlesource.com/c/v8/v8/+/755033/ [2] v8/v8@cbd8f42 https://chromium.googlesource.com/v8/v8/+/cbd8f4269f91e8ade38876092b433bda9ddb89a9 https://chromium-review.googlesource.com/c/1460952
The use of the non-maybe version of Function::Call has been deprecated for a while now[1][2]. This commit replaces calls to it with calls to the Maybe version and adds unwrapping. [1] v8/v8@66969fb https://chromium.googlesource.com/v8/v8/+/66969fb2ad6161d2d1da87cdd6fb50e1e6c970e5 https://codereview.chromium.org/993883002 [2] v8/v8@cbd8f42 https://chromium.googlesource.com/v8/v8/+/cbd8f4269f91e8ade38876092b433bda9ddb89a9 https://chromium-review.googlesource.com/c/v8/v8/+/1460952
The mentioned method has been deprecated for a while[1][2]. This commit replaces its use with use of the Maybe version and adds unwrapping. [1] v8/v8@5234d99 https://chromium.googlesource.com/v8/v8/+/5234d9977d637668e66b9e2e9f0456c6f97f749e https://codereview.chromium.org/993223003 [2] v8/v8@6f5e805 https://chromium.googlesource.com/v8/v8/+/6f5e8052847fc41df98a1e8f19211f399c6afc18 https://chromium-review.googlesource.com/c/v8/v8/+/1450115
ignisf
commented
May 28, 2019
| static VALUE rb_cDateTime = Qnil; | ||
|
|
||
| static Platform* current_platform = NULL; | ||
| static std::unique_ptr<Platform> current_platform = NULL; |
Contributor
Author
There was a problem hiding this comment.
@SamSaffron, check this out. The new platform API mandates the use of an std::unique_ptr.
Collaborator
|
OK lets try this out! CI is freaking out about bundler :( will get it sorted |
Contributor
Author
|
They should be releasing a new version of bundler that no longer has this issue. rubygems/bundler#6996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.